Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): view authorization #10066

Merged
merged 1 commit into from
Mar 23, 2024
Merged

feat(auth): view authorization #10066

merged 1 commit into from
Mar 23, 2024

Conversation

david-leifker
Copy link
Collaborator

@david-leifker david-leifker commented Mar 17, 2024 •
edited
Loading

Policy/Permissions:

  • PolicyConfig - Privileges organized by API Group and Operation
  • AuthUtils/AuthenticationUtil/ControllerUtil/ResourceUtils consolidated into AuthUtil
  • Added EXISTS_ENTIY privilege
  • Added CREATE_ENTITY privilege (CreateIfNotExistsValidator)
  • Deprecated SEARCH privilege

OpenAPI:

  • Added CreateIfEntityNotExists flag to OpenAPI create endpoints
  • Added CreateIfNotExists flag to OpenAPI create endpoints
  • Updated and added restoreIndices OpenAPI endpoints

Search Index:

  • Entity Indices systemCreated timestamp

Data Model:

  • Implemented ChangeType CREATE
  • Added ChangeType CREATE_ENTITY

Fixes:

  • Fix cache key calculation
  • Fix view privileges inheritance
  • Fix MeResolver for viewing self
  • Circular dependency between restli-client and restli-servlet-impl

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Mar 17, 2024
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from 8cc5c77 to 9392c84 Compare March 18, 2024 13:18
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from 9392c84 to e76bc11 Compare March 18, 2024 15:58
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from e76bc11 to c7b5760 Compare March 18, 2024 17:37
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from c7b5760 to fb4da43 Compare March 18, 2024 18:42
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from fb4da43 to 56c1d3b Compare March 18, 2024 21:24
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from 56c1d3b to 68bcbf7 Compare March 18, 2024 22:12
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from 68bcbf7 to 98cde30 Compare March 19, 2024 00:46
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch 2 times, most recently from dbed28c to d324ddd Compare March 19, 2024 14:58
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from d324ddd to a576aa8 Compare March 19, 2024 19:13
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from a576aa8 to 5ba1ca3 Compare March 19, 2024 19:58
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from 5ba1ca3 to 84d492a Compare March 21, 2024 14:47
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from 84d492a to 8754552 Compare March 22, 2024 21:00
@david-leifker
feat(auth): view authorization
096c36c 
PolicyConfig - Privileges organized by API Group and Operation
AuthUtils/AuthenticationUtil/ControllerUtil/ResourceUtils - consolidated into AuthUtil
Added EXISTS_ENTIY privilege
Added CREATE_ENTITY privilege (CreateIfEntityNotExistsValidator)
Added CreateIfEntityNotExists flag to OpenAPI create endpoints
Deprecated SEARCH privilege
Entity Indices systemCreated timestamp
Fix cache key calculation
Fix search view privileges inheritance
Fix MeResolver for viewing self
@david-leifker david-leifker force-pushed the search-access-controls-api-2 branch from 8754552 to 096c36c Compare March 23, 2024 00:50
@david-leifker david-leifker merged commit f9e64d0 into datahub-project:master Mar 23, 2024
42 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@david-leifker @sleeperdeep
feat(auth): view authorization (datahub-project#10066)
7b1df82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyanHolstien RyanHolstien RyanHolstien approved these changes

@chriscollins3456 chriscollins3456 Awaiting requested review from chriscollins3456

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-leifker @RyanHolstien