Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(sdk): Update API guide with example for Acryl #10072

Merged
merged 3 commits into from
Mar 18, 2024
Merged

docs(sdk): Update API guide with example for Acryl #10072

merged 3 commits into from
Mar 18, 2024

Conversation

gabe-lyons
Copy link
Contributor

This guide is confusing for hosted customers and a common source of pain. Adding context.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 18, 2024
hsheth2
hsheth2 approved these changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 changed the title Update API guide with example for Acryl docs(sdk): Update API guide with example for Acryl Mar 18, 2024
@gabe-lyons gabe-lyons enabled auto-merge (squash) March 18, 2024 20:21
@hsheth2 hsheth2 disabled auto-merge March 18, 2024 21:55
@hsheth2 hsheth2 merged commit 1248635 into master Mar 18, 2024
45 checks passed
@hsheth2 hsheth2 deleted the gabe-lyons-patch-1 branch March 18, 2024 21:55
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@gabe-lyons @sleeperdeep
docs(sdk): Update API guide with example for Acryl (datahub-project#1…
7d3de90 
…0072)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabe-lyons @hsheth2