-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ingest/bigquery): Respect dataset and table patterns when ingesting lineage via catalog api #10080
feat(ingest/bigquery): Respect dataset and table patterns when ingesting lineage via catalog api #10080
Conversation
schema_name=project_table.dataset_id, | ||
db_name=project_table.project, | ||
match_fully_qualified_schema_name=self.config.match_fully_qualified_names, | ||
) or not self.config.table_pattern.allowed(project_table.table_id): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.config.table_pattern
needs to be checked against qualified table name <project>.<dataset>.<table>
. I would suggest moving the table variable definition
table = f"{project_table.project}.{project_table.dataset_id}.{project_table.table_id}"
before if condition and using it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I didn't notice that table patterns expected qualified names. I'll have to update my own recipes as well. Updated in 5cbb1b1
cedeed6
to
5cbb1b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ing lineage via catalog api (datahub-project#10080)
Similar to when ingesting lineage via GCP audit logs:
datahub/metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/lineage.py
Lines 733 to 742 in 06ef2ad
Currently, when using
extract_lineage_from_catalog=True
a request is issued for every table in the project.Checklist