Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rate limiting to slack source #10082

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Add rate limiting to slack source #10082

merged 1 commit into from
Mar 20, 2024

Conversation

eboneil
Copy link
Contributor

@eboneil eboneil commented Mar 19, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 19, 2024
@eboneil eboneil marked this pull request as ready for review March 19, 2024 23:42
@eboneil eboneil requested a review from anshbansal March 20, 2024 00:26
@anshbansal anshbansal merged commit 446fbe5 into master Mar 20, 2024
54 checks passed
@anshbansal anshbansal deleted the slack-source-rate-limit-eboneil branch March 20, 2024 08:26
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@eboneil @sleeperdeep
fix(ingest/slack): add rate limiting to more places in slack source (d…
3884d12 
…atahub-project#10082)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eboneil @anshbansal