Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/datahub-gc): gc source to cleanup things #10085

Merged
merged 3 commits into from
Mar 21, 2024
Merged

feat(ingest/datahub-gc): gc source to cleanup things #10085

merged 3 commits into from
Mar 21, 2024

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Mar 20, 2024 •
edited
Loading

Currently only for cleaning up expired tokens but can be used for more later.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 20, 2024
@anshbansal anshbansal requested a review from eboneil March 20, 2024 12:33
eboneil
eboneil approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@eboneil eboneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some linting failures but besides that LGTM

@anshbansal anshbansal force-pushed the ab-datahub-gc-source-v1 branch from 17155e6 to 72e3029 Compare March 21, 2024 08:56
@anshbansal anshbansal merged commit 9659d60 into master Mar 21, 2024
53 checks passed
@anshbansal anshbansal deleted the ab-datahub-gc-source-v1 branch March 21, 2024 09:51
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@anshbansal @sleeperdeep
feat(ingest/datahub-gc): gc source to cleanup things (datahub-project…
a541a1e 
…#10085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboneil eboneil eboneil approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @eboneil