Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/dbt): fix config validator for skip_sources_in_lineage #10098

Merged
merged 2 commits into from
Mar 21, 2024
Merged

fix(ingest/dbt): fix config validator for skip_sources_in_lineage #10098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98272b9
fix(ingest/dbt): fix config validator for skip_sources_in_lineage
hsheth2 Mar 21, 2024
f257363
fix lint
hsheth2 Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/dbt/dbt_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,12 @@ def validate_include_column_lineage(
def validate_skip_sources_in_lineage(
cls, skip_sources_in_lineage: bool, values: Dict
) -> bool:
entites_enabled: DBTEntitiesEnabled = values["entities_enabled"]
if skip_sources_in_lineage and entites_enabled.sources == EmitDirective.YES:
entites_enabled: Optional[DBTEntitiesEnabled] = values.get("entities_enabled")
if (
skip_sources_in_lineage
and entites_enabled
and entites_enabled.sources == EmitDirective.YES
):
raise ValueError(
"When `skip_sources_in_lineage` is enabled, `entities_enabled.sources` must be set to NO."
)
Expand Down
24 changes: 24 additions & 0 deletions metadata-ingestion/tests/unit/test_dbt_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,30 @@ def test_dbt_entity_emission_configuration():
DBTCoreConfig.parse_obj(config_dict)


def test_dbt_config_skip_sources_in_lineage():
with pytest.raises(
ValidationError,
match="skip_sources_in_lineage.*entities_enabled.sources.*set to NO",
):
config_dict = {
"manifest_path": "dummy_path",
"catalog_path": "dummy_path",
"target_platform": "dummy_platform",
"skip_sources_in_lineage": True,
}
config = DBTCoreConfig.parse_obj(config_dict)

config_dict = {
"manifest_path": "dummy_path",
"catalog_path": "dummy_path",
"target_platform": "dummy_platform",
"skip_sources_in_lineage": True,
"entities_enabled": {"sources": "NO"},
}
config = DBTCoreConfig.parse_obj(config_dict)
assert config.skip_sources_in_lineage is True


def test_dbt_s3_config():
# test missing aws config
config_dict: dict = {
Expand Down
Loading