Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest): fix validators #10115

Merged
merged 5 commits into from
Mar 27, 2024
Merged

feat(ingest): fix validators #10115

merged 5 commits into from
Mar 27, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Mar 22, 2024 •
edited
Loading

  • Cleans up validation error types across the board
  • Makes the lineage source's urn validator throw an error

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Mar 22, 2024
@hsheth2 hsheth2 changed the title feat(ingest/lineage): add urn validator feat(ingest): fix validators Mar 27, 2024
@hsheth2 hsheth2 merged commit 25d9d66 into master Mar 27, 2024
55 of 57 checks passed
@hsheth2 hsheth2 deleted the lineage-validator branch March 27, 2024 22:20
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@hsheth2 @treff7es @sleeperdeep
feat(ingest): fix validators (datahub-project#10115)
bea89fa 
Co-authored-by: Tamas Nemeth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es