Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticsearch logging): log how long bulk execution took #10116

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented Mar 23, 2024

Elasticsearch bulk execution logs currently always print Took time ms as -1:

INFO  c.l.m.s.e.update.BulkListener:51 - Successfully fed bulk request. Number of events: 5 Took time ms: -1

The problem is that the printed time is actually the bulk ingest preprocessing time, which is -1 if ingest is not enabled.

This change now logs how long bulk execution took. The bulk ingest preprocessing time is only logged if available.

INFO  c.l.m.s.e.update.BulkListener - Successfully fed bulk request. Number of events: 12 Took time ms: 542

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 23, 2024
@david-leifker david-leifker merged commit a0d952d into master Mar 23, 2024
42 checks passed
@david-leifker david-leifker deleted the darnaut-elasticsearch-bulklistener-took-time branch March 23, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants