fix(retention): fix time-based retention #10118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug when maxAgeInSeconds (Integer) is greater than Integer.MAX_VALUE / 1000 (about 24 days). For example, if maxAgeInSeconds = Integer.MAX_VALUE / 1000 + 1, then maxAgeInSeconds * 1000 = -2147483296, and therefore all previous versions will be deleted.
Another option to fix this is to change the type of maxAgeInSeconds into long:
datahub/metadata-models/src/main/pegasus/com/linkedin/retention/TimeBasedRetention.pdl
Lines 6 to 8 in 088e7a8
Checklist