Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ingest): update doc & log detail #10139

Merged
merged 5 commits into from
Mar 27, 2024
Merged

chore(ingest): update doc & log detail #10139

merged 5 commits into from
Mar 27, 2024

Conversation

HuanjieGuo
Copy link
Contributor

@HuanjieGuo HuanjieGuo commented Mar 26, 2024 •
edited
Loading

This is the first time I run the ingestion module.

  • DOC has a little bit mismatching with the code.
  • NPE check
  • add the full path message in the exception

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata docs Issues and Improvements to docs community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 26, 2024
@HuanjieGuo HuanjieGuo changed the title chore(ingest): update doc & null check chore(ingest): update doc & log detail Mar 27, 2024
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Mar 27, 2024
@hsheth2 hsheth2 merged commit 654d991 into datahub-project:master Mar 27, 2024
56 of 57 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@HuanjieGuo @sleeperdeep
chore(ingest): update doc & log detail (datahub-project#10139)
7e1772b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community docs Issues and Improvements to docs ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HuanjieGuo @hsheth2