Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OBS-729 | Filters: Fix alignment on nested dropdown #10140

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

sumitappt
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@sumitappt
Copy link
Contributor Author

Here is the updated UI
Screenshot from 2024-03-26 22-38-05
Screenshot from 2024-03-26 22-37-55

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels Mar 26, 2024
Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, is there a way you can do this without hard coding the pixel amount? If we ever change the width of the first menu again, we'll have to update this as well. Or could we at least use a constant for the first menu's width, then use that in calculating left here

@sumitappt
Copy link
Contributor Author

Hmm, is there a way you can do this without hard coding the pixel amount? If we ever change the width of the first menu again, we'll have to update this as well. Or could we at least use a constant for the first menu's width, then use that in calculating left here

Done
image

Copy link
Collaborator

@asikowitz asikowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asikowitz asikowitz merged commit 85c54f5 into datahub-project:master Mar 27, 2024
35 of 36 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants