Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(openapi): fix index out of bounds for sort order #10168

Merged
merged 3 commits into from
Mar 29, 2024
Merged

fix(openapi): fix index out of bounds for sort order #10168

merged 3 commits into from
Mar 29, 2024

Conversation

RyanHolstien
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@RyanHolstien RyanHolstien self-assigned this Mar 29, 2024
@github-actions github-actions bot added the devops PR or Issue related to DataHub backend & deployment label Mar 29, 2024
david-leifker
david-leifker reviewed Mar 29, 2024
View reviewed changes
metadata-service/services/src/main/java/com/linkedin/metadata/graph/Edge.java Outdated
public static final String LIFE_CYCLE_OWNER_FIELD = "lifeCycleOwner";

public static final Map<String, SortOrder> KEY_SORTS =
Map.of(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might not guarantee order

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to list to preserve order

@RyanHolstien RyanHolstien merged commit c1eff59 into datahub-project:master Mar 29, 2024
35 of 36 checks passed
@RyanHolstien RyanHolstien deleted the fix/sortsForEdgeKeys branch March 29, 2024 18:43
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@RyanHolstien @sleeperdeep
fix(openapi): fix index out of bounds for sort order (datahub-project…
ed0f767 
…#10168)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees

@RyanHolstien RyanHolstien

Labels
devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanHolstien @david-leifker