-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(graph-retriever): implement graph retriever #10241
Merged
david-leifker
merged 9 commits into
datahub-project:master
from
david-leifker:graph-retriever
Apr 16, 2024
Merged
feat(graph-retriever): implement graph retriever #10241
david-leifker
merged 9 commits into
datahub-project:master
from
david-leifker:graph-retriever
Apr 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
PR or Issue related to the DataHub UI/UX
devops
PR or Issue related to DataHub backend & deployment
labels
Apr 8, 2024
david-leifker
force-pushed
the
graph-retriever
branch
from
April 8, 2024 18:55
5736466
to
5265205
Compare
david-leifker
force-pushed
the
graph-retriever
branch
from
April 9, 2024 13:07
6c0e871
to
ffd8b82
Compare
david-leifker
commented
Apr 10, 2024
@Nonnull TimeseriesAspectService timeseriesAspectService, | ||
@Nonnull UsageClientCacheConfig cacheConfig) { | ||
this.timeseriesAspectService = timeseriesAspectService; | ||
this.operationContextMap = Caffeine.newBuilder().maximumSize(500).build(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets add this as a constant!
RyanHolstien
approved these changes
Apr 10, 2024
* add graph retriever * extend operation context to entity services * reduce postConstruct() workarounds for circular dependencies * retriever context add (aspect + graph retriever)
david-leifker
force-pushed
the
graph-retriever
branch
from
April 16, 2024 11:51
9603914
to
11f02e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
devops
PR or Issue related to DataHub backend & deployment
product
PR or Issue related to the DataHub UI/UX
release-notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom plugins including validators, read/write mutators, and side effects currently have access to an
AspectRetriever
to read aspects while performing these functions. This PR introduces aGraphRetriever
to also allow fetching related entities from within these functions.OperationContext Notes:
RetrieverContext
introduced to contain both anAspectRetriever
and aGraphRetriever
Spring Notes:
postConstruct
methods to address circular dependencies are being eliminatedGraphRetriever Interface:
Example Interface Change For Validator (other interfaces are similar)
AspectRetriever -> RetrieverContext (with getters for Aspect & Graph versions)
Checklist