Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/snowflake): handle column level lineage for dbt temporary tables #10258

Merged
merged 4 commits into from
May 28, 2024
Merged

fix(ingest/snowflake): handle column level lineage for dbt temporary tables #10258

merged 4 commits into from
May 28, 2024

Conversation

john-claro-cko
Copy link
Contributor

@john-claro-cko john-claro-cko commented Apr 9, 2024 •
edited
Loading

We have noticed a vast improvement in column level lineages once this has been applied. This means that Snowflake ingestions are not able to link column level lineages with DBT temporary tables as the table_upstreams_with_column_lineage() function returns them as DATABASE.SCHEMA.TABLE__DMP_TMP but in Snowflake these tables are named as DATABASE.SCHEMA.TABLE

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Apr 9, 2024
@john-claro-cko john-claro-cko changed the title fix(ingestion/snowflake): handle column level lineage for dbt temporary tables fix(ingest/snowflake): handle column level lineage for dbt temporary tables Apr 9, 2024
@hsheth2 hsheth2 requested a review from mayurinehate April 10, 2024 17:15
@hsheth2 hsheth2 self-assigned this Apr 10, 2024
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label May 22, 2024
@anshbansal anshbansal merged commit 776e5c4 into datahub-project:master May 28, 2024
58 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@john-claro-cko @hsheth2 @sleeperdeep
fix(ingest/snowflake): handle column level lineage for dbt temporary …
3470441 
…tables (datahub-project#10258)

Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayurinehate mayurinehate mayurinehate approved these changes

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees

@hsheth2 hsheth2

Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@john-claro-cko @hsheth2 @mayurinehate @anshbansal