fix(ingest/mode): Improve query lineage #10284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
Using id if name is None for a dashboard
- Using set for chart fields to make sure we don't have duplicates - Generating less warning on missing chart type
treff7es
changed the title
hsheth2
approved these changes
Apr 16, 2024
| @@ -268,7 +285,7 @@ def __init__(self, ctx: PipelineContext, config: ModeConfig): | |||
| except HTTPError as http_error: | |||
| self.report.report_failure( | |||
| key="mode-session", | |||
| reason=f"Unable to retrieve user " | |||
| reason=f"Unable to verify connection" | |||
| f"{self.config.token} information, " | |||
There was a problem hiding this comment.
not sure we want to log the token
unless this is not an auth token, but something else
There was a problem hiding this comment.
ahh, correct, I didn't notice we have this.
We shouldn't log this, you are right.
| @@ -329,7 +361,7 @@ def construct_dashboard( | |||
| paths=[ | |||
| f"/mode/{self.config.workspace}/" | |||
| f"{space_name}/" | |||
| f"{report_info.get('name')}" | |||
| f"{title if title else report_info.get('id', '')}" | |||
There was a problem hiding this comment.
maybe let's format it nicer e.g. "Dashboard # 023"
Adding sql as description to query entity
hsheth2
approved these changes
May 8, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist