-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add content describing diff between datahub and acryl datahub #10301
docs: add content describing diff between datahub and acryl datahub #10301
Conversation
|
||
## How to read this list | ||
|
||
Not a fan of checkboxes? Neither are we. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we work with the Design team to create some static images so we're not limited to markdown formatting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree, it's somewhat hard to understand this comparsion intuitively. I don't think it would be too crazy to use markdown table with checkboxes, something like this ; https://datahubproject.io/docs/api/datahub-apis#datahub-api-comparison
If the design is too bland we can do something like the table on a acryl website ; https://www.acryldata.io/
Yet i'm not a big fan of static images becuase the text wouldn't be searchable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, i think we wouldnt need "How to read this list" if we go with the checkboxes. @shirshanka let me know if you need help with this.
Addressed review comments. PTAL @yoonhyejin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some nitpick comments but overall looks great. I hope we can link out more doc contents with this table in the future :)
Co-authored-by: Hyejin Yoon <[email protected]>
Co-authored-by: Hyejin Yoon <[email protected]>
…atahub-project#10301) Co-authored-by: Hyejin Yoon <[email protected]>
Checklist