Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingest/sigma): fix stateful ingestion #10321

Merged
merged 1 commit into from
Apr 18, 2024
Merged

feat(ingest/sigma): fix stateful ingestion #10321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions metadata-ingestion/src/datahub/ingestion/source/sigma/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
)
from datahub.ingestion.source.state.stale_entity_removal_handler import (
StaleEntityRemovalSourceReport,
StatefulStaleMetadataRemovalConfig,
)
from datahub.ingestion.source.state.stateful_ingestion_base import (
StatefulIngestionConfigBase,
Expand Down Expand Up @@ -84,3 +85,5 @@ class SigmaSourceConfig(
default={},
description="A mapping of the sigma workspace/workbook/chart folder path to all chart's data sources platform details present inside that folder path.",
)

stateful_ingestion: Optional[StatefulStaleMetadataRemovalConfig] = None
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/sigma/sigma.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class SigmaSource(StatefulIngestionSourceBase, TestableSource):
platform: str = "sigma"

def __init__(self, config: SigmaSourceConfig, ctx: PipelineContext):
super(SigmaSource, self).__init__(config, ctx)
super().__init__(config, ctx)
self.config = config
self.reporter = SigmaSourceReport()
self.dataset_upstream_urn_mapping: Dict[str, List[str]] = {}
Expand Down
1 change: 0 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/superset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,6 @@ class SupersetSource(StatefulIngestionSourceBase):
config: SupersetConfig
report: StaleEntityRemovalSourceReport
platform = "superset"
stale_entity_removal_handler: StaleEntityRemovalHandler

def __hash__(self):
return id(self)
Expand Down
Loading