Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ingest/profiling): allow unique count queries to be combined #10322

Merged
merged 1 commit into from
Apr 18, 2024
Merged

feat(ingest/profiling): allow unique count queries to be combined #10322

merged 1 commit into from
Apr 18, 2024

Conversation

hsheth2
Copy link
Collaborator

@hsheth2 hsheth2 commented Apr 18, 2024

This moves us from issuing one unique count query per column to one per table.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@hsheth2
feat(ingest/profiling): allow unique count queries to be combined
038cf30 
This moves us from issuing one unique count query per column to one per
table.
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 18, 2024
@hsheth2 hsheth2 merged commit f99f738 into master Apr 18, 2024
58 checks passed
@hsheth2 hsheth2 deleted the bigquery-combine-approx-row-count branch April 18, 2024 17:47
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@hsheth2 @sleeperdeep
feat(ingest/profiling): allow unique count queries to be combined (da…
32d982a 
…tahub-project#10322)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsheth2 @treff7es