docs: add guides on forms & structured properties #10340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoonhyejin
changed the title
covers Custom and Structured Properties; includes screenshots
Rename Forms > Documentation Forms
yoonhyejin
commented
May 21, 2024
| @@ -0,0 +1,156 @@ | |||
| import FeatureAvailability from '@site/src/components/FeatureAvailability'; | |||
|
|
|||
There was a problem hiding this comment.
Suggested change
| import Tabs from '@theme/Tabs'; | |
| import TabItem from '@theme/TabItem'; | |
There was a problem hiding this comment.
@maggiehays you need to import tabs/tabitems first to use tabs
| </TabItem> | ||
| </Tabs> | ||
|
|
||
| :::Note |
There was a problem hiding this comment.
Suggested change
| :::Note | |
| :::note |
There was a problem hiding this comment.
i think this is because the adminition is case-sensitive : https://docusaurus.io/docs/markdown-features/admonitions
maggiehays
approved these changes
May 21, 2024
There was a problem hiding this comment.
@yoonhyejin this first pass is ready to go!
Not a merge blocker, but I noticed the sidebar is adding these two feature guides out of ABC order and appending them to the top of the section. If it's a quick fix, let's slot it in, otherwise let's get this PR merged to unblock @anshbansal
|
@maggiehays just pushed a quick fix on the sidebar order! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maggie's open questions:
Checklist