Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metabase): add stateful ingestion #10360

Merged
merged 1 commit into from
May 2, 2024
Merged

feat(metabase): add stateful ingestion #10360

merged 1 commit into from
May 2, 2024

Conversation

paguos
Copy link
Contributor

@paguos paguos commented Apr 23, 2024 •
edited
Loading

Modify the metabase source to support stateful ingestion

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Closes #10365

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Apr 23, 2024
@paguos paguos force-pushed the feat/metabase-stateful-ingestion branch from 54f40b9 to 2f06889 Compare April 23, 2024 11:49
@paguos paguos force-pushed the feat/metabase-stateful-ingestion branch from 2f06889 to d8c4075 Compare April 23, 2024 12:10
@paguos paguos force-pushed the feat/metabase-stateful-ingestion branch 2 times, most recently from b4d64f6 to 198fd46 Compare April 23, 2024 12:49
@paguos
feat(metabase): add stateful ingestion
5015201 
Modify the metabase source to support stateful ingestion

Signed-off-by: Pablo Osinaga <[email protected]>
@paguos paguos force-pushed the feat/metabase-stateful-ingestion branch from 198fd46 to 5015201 Compare April 23, 2024 13:16
hsheth2
hsheth2 approved these changes May 2, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 merged commit 0b99145 into datahub-project:master May 2, 2024
57 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@paguos @sleeperdeep
feat(metabase): add stateful ingestion (datahub-project#10360)
18f96d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metabase: Removed/archived charts are not removed from Datahub
2 participants
@paguos @hsheth2