Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): do not lower-case dataset key parts i.e. data platform … #10385

Merged
merged 4 commits into from
Apr 29, 2024
Merged

fix(backend): do not lower-case dataset key parts i.e. data platform … #10385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
287f3fb
fix(backend): do not lower-case dataset key parts i.e. data platform …
ksrinath Apr 26, 2024
86d8578
Merge branch 'master' into fix/dataplatform-instance-capitalization
ksrinath Apr 26, 2024
835f1db
testcase fix
ksrinath Apr 26, 2024
c71d2d7
Merge branch 'fix/dataplatform-instance-capitalization' of https://gi…
ksrinath Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions metadata-io/src/main/java/com/linkedin/metadata/search/utils/BrowsePathV2Utils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@ public static BrowsePathsV2 getDefaultBrowsePathV2(
BrowsePathEntryArray defaultDatasetPathEntries =
getDefaultDatasetPathEntries(dsKey.getName(), dataPlatformDelimiter);
if (defaultDatasetPathEntries.size() > 0) {
browsePathEntries.addAll(
getDefaultDatasetPathEntries(dsKey.getName().toLowerCase(), dataPlatformDelimiter));
browsePathEntries.addAll(defaultDatasetPathEntries);
} else {
browsePathEntries.add(createBrowsePathEntry(DEFAULT_FOLDER_NAME, null));
}
Expand Down
4 changes: 2 additions & 2 deletions metadata-io/src/test/java/com/linkedin/metadata/search/utils/BrowsePathV2UtilsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,8 +146,8 @@ public void testGetDefaultBrowsePathV2WithoutContainers() throws URISyntaxExcept
BrowsePathV2Utils.getDefaultBrowsePathV2(
mock(OperationContext.class), datasetUrn, this.registry, '.', mockService, true);
BrowsePathEntryArray expectedPath = new BrowsePathEntryArray();
BrowsePathEntry entry1 = new BrowsePathEntry().setId("test");
BrowsePathEntry entry2 = new BrowsePathEntry().setId("a");
BrowsePathEntry entry1 = new BrowsePathEntry().setId("Test");
BrowsePathEntry entry2 = new BrowsePathEntry().setId("A");
expectedPath.add(entry1);
expectedPath.add(entry2);
Assert.assertEquals(browsePathsV2.getPath(), expectedPath);
Expand Down
Loading