Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/bigquery): Fixing double sanitization of urns #10386

Merged
merged 3 commits into from
May 3, 2024
Merged

fix(ingest/bigquery): Fixing double sanitization of urns #10386

merged 3 commits into from
May 3, 2024

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Apr 26, 2024
hsheth2
hsheth2 approved these changes Apr 28, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'd much prefer if we had proper types e.g. "SanitizedBQRef" and "RawBQRef" - that'd let us lean on the mypy type checker to make sure we're getting these details right

@hsheth2 hsheth2 merged commit 4e47933 into datahub-project:master May 3, 2024
57 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@treff7es @sleeperdeep
fix(ingest/bigquery): Fixing double sanitization of urns (datahub-pro…
0b54f0c 
…ject#10386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@treff7es @hsheth2