Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(graphql): Improve logging of GraphQL requests #10404

Merged
merged 1 commit into from
May 2, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented May 1, 2024

  • Log GraphQL requests received and being executed
  • Log GraphQL queries to a separate debug log file
  • Log duration and result size of executed requests
2024-05-01 05:14:59,354 [qtp752848266-28] INFO  c.datahub.graphql.GraphQLController:120 - Processing request, operation: getQuickFilters, actor urn: urn:li:corpuser:datahub
2024-05-01 05:14:59,355 [ForkJoinPool.commonPool-worker-6] INFO  c.datahub.graphql.GraphQLController:125 - Executing operation getQuickFilters for qtp752848266-28
2024-05-01 05:14:59,406 [ForkJoinPool.commonPool-worker-6] INFO  c.datahub.graphql.GraphQLController:148 - Executed operation getQuickFilters in 50 ms
2024-05-01 05:14:59,407 [ForkJoinPool.commonPool-worker-6] INFO  c.datahub.graphql.GraphQLController:153 - Operation getQuickFilters execution result size: 101
2024-05-01 05:14:59,355 [qtp752848266-28] DEBUG c.datahub.graphql.GraphQLController - Query: query getQuickFilters($input: GetQuickFiltersInput!) {
  getQuickFilters(input: $input) {
    quickFilters {
      field
      value
      entity {
        urn
        type
        ... on DataPlatform {
          ...platformFields
          __typename
        }
        __typename
      }
      __typename
    }
    __typename
  }
}
...

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels May 1, 2024
@darnaut darnaut force-pushed the graphql-logging branch from 509eeb1 to 3ce8a7c Compare May 1, 2024 06:28
@darnaut darnaut force-pushed the graphql-logging branch from 3ce8a7c to 8ef3b43 Compare May 2, 2024 00:14
@darnaut darnaut merged commit f3c42f6 into datahub-project:master May 2, 2024
36 checks passed
@darnaut darnaut deleted the graphql-logging branch May 2, 2024 02:12
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants