Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ingest): fix typos and clarify ingestion recipe docs #10405

Merged
merged 2 commits into from
May 8, 2024
Merged

docs(ingest): fix typos and clarify ingestion recipe docs #10405

merged 2 commits into from
May 8, 2024

Conversation

guyr-ziprecruiter
Copy link
Contributor

@guyr-ziprecruiter guyr-ziprecruiter commented May 1, 2024 •
edited
Loading

Fixed typo + made things clearer (imho)

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@guyr-ziprecruiter
Fixed type in the word "recipe" and then some
fb9de85 
Fixed typo + made things clearer (imho)
@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels May 1, 2024
guyr-ziprecruiter
guyr-ziprecruiter commented May 1, 2024
View reviewed changes
metadata-ingestion/cli-ingestion.md

```yaml
# my_reipe.yml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the actual typo I wanted to fix.

@hsheth2 hsheth2 changed the title Fixed type in the word "recipe" and then some docs(ingest): fix typos and clarify ingestion recipe docs May 2, 2024
@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label May 2, 2024
@hsheth2 hsheth2 merged commit 232b989 into datahub-project:master May 8, 2024
48 of 50 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@guyr-ziprecruiter @sleeperdeep
docs(ingest): fix typos and clarify ingestion recipe docs (datahub-pr…
f08ee49 
…oject#10405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guyr-ziprecruiter @hsheth2