Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql): log query name if operation name is not provided #10420

Merged
merged 1 commit into from
May 2, 2024
Merged

feat(graphql): log query name if operation name is not provided #10420

merged 1 commit into from
May 2, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented May 2, 2024

GraphQL operation name is an optional field only required if multiple operations are present. If not present, use query name for logging.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels May 2, 2024
@darnaut darnaut merged commit 4ebc31c into datahub-project:master May 2, 2024
37 checks passed
@darnaut darnaut deleted the graphql-logging-operation-name branch May 2, 2024 23:19
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@darnaut @sleeperdeep
feat(graphql): log query name if operation name is not provided (data…
a46e6c4 
…hub-project#10420)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darnaut @david-leifker