Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): improve authentication flow logging #10428

Merged
merged 1 commit into from
May 3, 2024
Merged

feat(auth): improve authentication flow logging #10428

merged 1 commit into from
May 3, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented May 3, 2024

  • Log messages for successful and failed login attempts
  • Log messages whenever a new session token is generated

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels May 3, 2024
david-leifker
david-leifker approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me to add logging here. Just make sure to do a quick review of potential places where tokens might be leaked into the log.

@darnaut darnaut force-pushed the auth-flow-logging branch from 45f98fd to 09999ce Compare May 3, 2024 17:39
@darnaut darnaut merged commit 5a686c5 into datahub-project:master May 3, 2024
34 of 36 checks passed
@darnaut darnaut deleted the auth-flow-logging branch May 3, 2024 19:14
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@darnaut @sleeperdeep
feat(auth): improve authentication flow logging (datahub-project#10428)
bb4be6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darnaut @david-leifker