Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metadata-service): add PE processor to component scan #10462

Merged
merged 1 commit into from
May 9, 2024
Merged

fix(metadata-service): add PE processor to component scan #10462

merged 1 commit into from
May 9, 2024

Conversation

darnaut
Copy link
Collaborator

@darnaut darnaut commented May 9, 2024

#10290 removed com.linkedin.metadata.service and com.datahub.event from GMS' component scan but these are required in order to instantiate com.datahub.event.PlatformEventProcessor when PE_CONSUMER_ENABLED is set to true for GMS.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@darnaut darnaut changed the title fix(metadata-service): tweak component scan to include required components fix(metadata-service): add PE processor to component scan May 9, 2024
@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels May 9, 2024
@david-leifker david-leifker merged commit 7adf726 into datahub-project:master May 9, 2024
35 of 36 checks passed
@darnaut darnaut deleted the gms-component-scan branch May 9, 2024 13:11
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@darnaut @sleeperdeep
fix(metadata-service): add PE processor to component scan (datahub-pr…
37ca636 
…oject#10462)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darnaut @david-leifker