Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fabricType): add fabric type RVW #10472

Merged
merged 4 commits into from
May 9, 2024
Merged

feat(fabricType): add fabric type RVW #10472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ece09f5
add fabric type rvw
eboneil May 9, 2024
1933bc9
modify generated files
eboneil May 9, 2024
7968052
update docs
eboneil May 9, 2024
fc8b520
Merge remote-tracking branch 'upstream/master' into add-fabric-rvw
eboneil May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions datahub-graphql-core/src/main/resources/entity.graphql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2685,6 +2685,11 @@ enum FabricType {
Designates corporation fabrics
"""
CORP

"""
Designates review fabrics
"""
RVW
}

"""
Expand Down
1 change: 1 addition & 0 deletions docs/how/updating-datahub.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
### Breaking Changes

- #10419 - `aws_region` is now a required configuration in the DynamoDB connector. The connector will no longer loop through all AWS regions; instead, it will only use the region passed into the recipe configuration.
- #10472 - `RVW` added as a FabricType. No rollbacks allowed once metadata with this fabric type is added without manual cleanups in databases.

### Potential Downtime

Expand Down
5 changes: 5 additions & 0 deletions li-utils/src/main/pegasus/com/linkedin/common/FabricType.pdl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,9 @@ enum FabricType {
* Designates corporation fabrics
*/
CORP

/**
* Designates review fabrics
*/
RVW
}
5 changes: 3 additions & 2 deletions metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@
"name" : "FabricType",
"namespace" : "com.linkedin.common",
"doc" : "Fabric group type",
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ],
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ],
"symbolDocs" : {
"CORP" : "Designates corporation fabrics",
"DEV" : "Designates development fabrics",
Expand All @@ -845,7 +845,8 @@
"QA" : "Designates quality assurance fabrics",
"STG" : "Designates staging fabrics",
"TEST" : "Designates testing fabrics",
"UAT" : "Designates user acceptance testing fabrics"
"UAT" : "Designates user acceptance testing fabrics",
"RVW" : "Designates review fabrics"
}
}, {
"type" : "record",
Expand Down
5 changes: 3 additions & 2 deletions metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@
"name" : "FabricType",
"namespace" : "com.linkedin.common",
"doc" : "Fabric group type",
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ],
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ],
"symbolDocs" : {
"CORP" : "Designates corporation fabrics",
"DEV" : "Designates development fabrics",
Expand All @@ -845,7 +845,8 @@
"QA" : "Designates quality assurance fabrics",
"STG" : "Designates staging fabrics",
"TEST" : "Designates testing fabrics",
"UAT" : "Designates user acceptance testing fabrics"
"UAT" : "Designates user acceptance testing fabrics",
"RVW" : "Designates review fabrics"
}
}, {
"type" : "record",
Expand Down
5 changes: 3 additions & 2 deletions metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@
"name" : "FabricType",
"namespace" : "com.linkedin.common",
"doc" : "Fabric group type",
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ],
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ],
"symbolDocs" : {
"CORP" : "Designates corporation fabrics",
"DEV" : "Designates development fabrics",
Expand All @@ -587,7 +587,8 @@
"QA" : "Designates quality assurance fabrics",
"STG" : "Designates staging fabrics",
"TEST" : "Designates testing fabrics",
"UAT" : "Designates user acceptance testing fabrics"
"UAT" : "Designates user acceptance testing fabrics",
"RVW" : "Designates review fabrics"
}
}, {
"type" : "record",
Expand Down
5 changes: 3 additions & 2 deletions ...ata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@
"name" : "FabricType",
"namespace" : "com.linkedin.common",
"doc" : "Fabric group type",
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ],
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ],
"symbolDocs" : {
"CORP" : "Designates corporation fabrics",
"DEV" : "Designates development fabrics",
Expand All @@ -587,7 +587,8 @@
"QA" : "Designates quality assurance fabrics",
"STG" : "Designates staging fabrics",
"TEST" : "Designates testing fabrics",
"UAT" : "Designates user acceptance testing fabrics"
"UAT" : "Designates user acceptance testing fabrics",
"RVW" : "Designates review fabrics"
}
}, {
"type" : "record",
Expand Down
5 changes: 3 additions & 2 deletions metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -834,7 +834,7 @@
"name" : "FabricType",
"namespace" : "com.linkedin.common",
"doc" : "Fabric group type",
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP" ],
"symbols" : [ "DEV", "TEST", "QA", "UAT", "EI", "PRE", "STG", "NON_PROD", "PROD", "CORP", "RVW" ],
"symbolDocs" : {
"CORP" : "Designates corporation fabrics",
"DEV" : "Designates development fabrics",
Expand All @@ -845,7 +845,8 @@
"QA" : "Designates quality assurance fabrics",
"STG" : "Designates staging fabrics",
"TEST" : "Designates testing fabrics",
"UAT" : "Designates user acceptance testing fabrics"
"UAT" : "Designates user acceptance testing fabrics",
"RVW" : "Designates review fabrics"
}
}, {
"type" : "record",
Expand Down
Loading