fix(ingestion/airflow-plugin): airflow remove old tasks #10485
Conversation
github-actions
bot
added
the
ingestion
dushayntAW
force-pushed
the
fix/ING-447/airflow-not-removing-old-task
branch
2 times, most recently
from
ebd7762 to
49c689c
Compare
| logger.debug("Initiating the cleanup of obsselete data from datahub") | ||
|
|
||
| ingested_dataflow_urns = list( | ||
| self.graph.get_urns_by_filter( |
There was a problem hiding this comment.
I think you should filter for cluster as well; otherwise if user has multiple Airflow instance you will delete dags which you shouldn't.
There was a problem hiding this comment.
I am filtering the entire URN which is already having the cluster i.e. urn:li:dataFlow:(airflow,simple_dag,prod)
So, still we need to match/filter cluster explicitly? or my understanding is wrong.
There was a problem hiding this comment.
If you check here we use cluster or env to generate the DataFlow Urns, so it is part of the urn. ->
This means if the env or cluster is set and has multiple Airflow environments like DEV and PROD, then your query will return the urns for both PROD and DEV, which we don't want in this case as these are different Airflow environment.
You should add cluster/env as a filter parameter.
| airflow_job_urns: List = [] | ||
|
|
||
| for dag in all_airflow_dags: | ||
| flow_urn = builder.make_data_flow_urn( |
There was a problem hiding this comment.
cluster should be passed in if exists
There was a problem hiding this comment.
same as other comment
| logger.debug("Initiating the cleanup of obsselete data from datahub") | ||
|
|
||
| ingested_dataflow_urns = list( | ||
| self.graph.get_urns_by_filter( |
There was a problem hiding this comment.
If you check here we use cluster or env to generate the DataFlow Urns, so it is part of the urn. ->
This means if the env or cluster is set and has multiple Airflow environments like DEV and PROD, then your query will return the urns for both PROD and DEV, which we don't want in this case as these are different Airflow environment.
You should add cluster/env as a filter parameter.
…e tasks and pipelines based on the cluster
Checklist