Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ingestion/tableau): optionally ingest multiple sites and create site containers #10498

Merged
merged 15 commits into from
Jul 9, 2024
Merged

feat(ingestion/tableau): optionally ingest multiple sites and create site containers #10498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ec6aef3
feat(ingest/tableau): optionally ingest multiple sites and create sit…
May 14, 2024
20a1d4e
fix(ingestion/tableau): fix wrong site id when fetching site
May 14, 2024
acc4480
refactor(ingestion/tableau): refactor code to use built-in switch_sit…
May 14, 2024
31c8f18
fix(linting): fix linting issues and cleanup
May 14, 2024
f838a5b
Merge branch 'master' of https://github.com/haeniya/datahub into feat…
May 30, 2024
c85d387
config field description improved, add teradata as two-tier database
Jun 27, 2024
fc3a05b
pr feedback: refactor code and extract TableauSiteSource into its own…
Jul 2, 2024
30c81b0
fix platform instance not being added to the browsepaths
Jul 5, 2024
0727699
fix platform instance not being added to the browsepaths
Jul 5, 2024
485262b
fix linting issues
Jul 5, 2024
c48d25d
fix linting in tableau_common
Jul 5, 2024
27d40ed
add release documentation and fix unit and integration tests
Jul 9, 2024
85bab47
Merge branch 'master' of https://github.com/haeniya/datahub into feat…
Jul 9, 2024
7651382
fix integration tests and add new tests for new functionality
Jul 9, 2024
2f502fc
fix linting issues
Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/how/updating-datahub.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe
No loss of functionality expected unless explicitly mentioned in Breaking Changes.

### Other Notable Changes
- #10498 - Tableau ingestion can now be configured to ingest multiple sites at once and add the sites as containers. The feature is currently only available for Tableau Server.

## 0.13.3

Expand Down
333 changes: 229 additions & 104 deletions metadata-ingestion/src/datahub/ingestion/source/tableau.py
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 6 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/tableau_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,12 @@ def get_overridden_info(
):
platform_instance = database_hostname_to_platform_instance_map.get(hostname)

if original_platform in ("athena", "hive", "mysql"): # Two tier databases
if original_platform in (
"athena",
"hive",
"mysql",
"teradata",
): # Two tier databases
upstream_db = None

return upstream_db, platform_instance, platform, original_platform
Expand Down
1 change: 1 addition & 0 deletions metadata-ingestion/src/datahub/ingestion/source/tableau_constant.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,5 @@
DASHBOARDS_CONNECTION = "dashboardsConnection"
EMBEDDED_DATA_SOURCES_CONNECTION = "embeddedDatasourcesConnection"
PROJECT = "Project"
SITE = "Site"
IS_UNSUPPORTED_CUSTOM_SQL = "isUnsupportedCustomSql"
Loading
Loading