-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gms/autosuggestion): autosuggestion query not returning the result if the query text has a prefix or suffix '-' on the search field #10512
Merged
samblackk
merged 6 commits into
datahub-project:master
from
siladitya2:fix-autosuggestion
May 31, 2024
Merged
fix(gms/autosuggestion): autosuggestion query not returning the result if the query text has a prefix or suffix '-' on the search field #10512
samblackk
merged 6 commits into
datahub-project:master
from
siladitya2:fix-autosuggestion
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… urn contains special character '-'
github-actions
bot
added
product
PR or Issue related to the DataHub UI/UX
community-contribution
PR or Issue raised by member(s) of DataHub Community
datahub-community-champion
PRs authored by DataHub Community Champions
labels
May 15, 2024
siladitya2
changed the title
fix(gms/autosuggestion): autosuggestion query not returning result if urn contains special character '-'
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is inside the special character '-'
May 15, 2024
siladitya2
changed the title
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is inside the special character '-'
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is between the special character '-'
May 15, 2024
siladitya2
changed the title
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is between the special character '-'
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is in between the special character '-'
May 15, 2024
siladitya2
changed the title
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is in between the special character '-'
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is in between the special character '-' of the search field
May 15, 2024
siladitya2
changed the title
fix(gms/autosuggestion): autosuggestion query not suggesting result if the search text is in between the special character '-' of the search field
fix(gms/autosuggestion): autosuggestion query not returning result if the query text is in between of the search field
May 15, 2024
siladitya2
changed the title
fix(gms/autosuggestion): autosuggestion query not returning result if the query text is in between of the search field
fix(gms/autosuggestion): autosuggestion query not returning the result if the query text has a prefix or suffix '-' on the search field
May 15, 2024
samblackk
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a simple fix to me. Approving.
samblackk
added
the
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
label
May 22, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…t if the query text has a prefix or suffix '-' on the search field (datahub-project#10512) Co-authored-by: si-chakraborty <[email protected]>
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
…t if the query text has a prefix or suffix '-' on the search field (#10512) Co-authored-by: si-chakraborty <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
community-contribution
PR or Issue raised by member(s) of DataHub Community
datahub-community-champion
PRs authored by DataHub Community Champions
merge-pending-ci
A PR that has passed review and should be merged once CI is green.
product
PR or Issue related to the DataHub UI/UX
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We have found that autosuggestion query not returning the result if an
urn
or any autosuggestion enabled field (type TEXT) of an entity contains a prefix or suffix '-' with the query text value.Note: Searching is working fine, issue only with Auto suggestion here.
As an example:
urn1:
urn:li:dataset:(urn:li:dataPlatform:s3,databox.arn:aws:s3:::dl-adityas,PROD)
urn2:
urn:li:dataset:(urn:li:dataPlatform:s3,databox.arn:aws:s3:::dl-adityas-datalake-3vin0mkuxmps/cv-parsing-export,PROD)
Above urns are not auto suggested when we type
adityas
in the datahub search bar. (please see below UI screenshot)Test Result Before fix:
Fix:
we need to search the query string (
adityas
) here with the below query(urn.delimited
):Test Result After fix:
Checklist