Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): DataProcessInstance.emit_process_end() ignored start_timestamp_millis #10539

Merged
merged 2 commits into from
May 24, 2024
Merged

fix(ingest): DataProcessInstance.emit_process_end() ignored start_timestamp_millis #10539

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a038a82
fix(ingest): use prev.ignored arg in DataProcessInstance
obaltian May 19, 2024
5338f8c
Merge branch 'master' into patch-1
obaltian May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions metadata-ingestion/src/datahub/api/entities/dataprocess/dataprocess_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,8 @@ def end_event_mcp(
:param result: (InstanceRunResult) the result of the run
:param result_type: (string) It identifies the system where the native result comes from like Airflow, Azkaban
:param attempt: (int) the attempt number of this execution
:param start_timestamp_millis: (Optional[int]) the start time of the execution in milliseconds

"""
mcp = MetadataChangeProposalWrapper(
entityUrn=str(self.urn),
Expand Down Expand Up @@ -215,12 +217,15 @@ def emit_process_end(
:param result_type: (string) It identifies the system where the native result comes from like Airflow, Azkaban
:param attempt: (int) the attempt number of this execution
:param callback: (Optional[Callable[[Exception, str], None]]) the callback method for KafkaEmitter if it is used
:param start_timestamp_millis: (Optional[int]) the start time of the execution in milliseconds

"""
for mcp in self.end_event_mcp(
end_timestamp_millis=end_timestamp_millis,
result=result,
result_type=result_type,
attempt=attempt,
start_timestamp_millis=start_timestamp_millis,
):
self._emit_mcp(mcp, emitter, callback)

Expand Down
Loading