Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/mode): Adding Dashboards into containers #10563

Merged
merged 2 commits into from
May 22, 2024

Conversation

treff7es
Copy link
Contributor

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label May 21, 2024
@@ -1464,6 +1469,10 @@ def emit_dashboard_mces(self) -> Iterable[MetadataWorkUnit]:
aspect=SubTypesClass(typeNames=[BIAssetSubTypes.MODE_REPORT]),
)
yield mcpw.as_workunit()
yield from add_dataset_to_container(
container_key=space_container_key,
dataset_urn=dashboard_snapshot_from_report.urn,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this saying dataset_urn= is super confusing

@treff7es treff7es merged commit f831518 into datahub-project:master May 22, 2024
56 of 58 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants