feat(fieldpaths): prevent duplicate field paths #10590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedro93
reviewed
May 28, 2024
|
|
||
| private static boolean changeTypeFilter(BatchItem item) { | ||
| return !ChangeType.DELETE.equals(item.getChangeType()) | ||
| && !ChangeType.PATCH.equals(item.getChangeType()); |
There was a problem hiding this comment.
In the entity-registry config PATCH is marked as a supported type.
There was a problem hiding this comment.
I believe the idea here is that it can't occur for patches because patches require a keyed operation which prevents duplicates, but @david-leifker please verify.
There was a problem hiding this comment.
PATCH is not needed since mutation occurs after PATCH change type has been converted to UPSERT
RyanHolstien
approved these changes
May 28, 2024
aabharti-visa
pushed a commit
to aabharti-visa/datahub
that referenced
this pull request
May 30, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding read/write mutator to protect against invalid field path columns. The duplicate columns are dropped. This prevents a UI bug from an ingestion error.
Checklist