-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data quality): update models, add assertions cli with snowflake integration #10602
Merged
jjoyce0510
merged 11 commits into
datahub-project:master
from
mayurinehate:assertion_cli
May 31, 2024
Merged
feat(data quality): update models, add assertions cli with snowflake integration #10602
jjoyce0510
merged 11 commits into
datahub-project:master
from
mayurinehate:assertion_cli
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
PR or Issue related to the ingestion of metadata
product
PR or Issue related to the DataHub UI/UX
devops
PR or Issue related to DataHub backend & deployment
labels
May 28, 2024
jjoyce0510
reviewed
May 28, 2024
Constants.GLOBAL_TAGS_ASPECT_NAME); | ||
|
||
Constants.GLOBAL_TAGS_ASPECT_NAME, | ||
Constants.ASSERTION_ACTIONS_ASPECT_NAME); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
jjoyce0510
reviewed
May 28, 2024
metadata-ingestion/examples/library/assertions_configuration.yml
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
May 28, 2024
metadata-ingestion/src/datahub/api/entities/assertion/compiler_interface.py
Show resolved
Hide resolved
jjoyce0510
reviewed
May 28, 2024
metadata-ingestion/src/datahub/api/entities/assertion/compiler_interface.py
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
May 28, 2024
metadata-service/services/src/main/java/com/linkedin/metadata/service/util/AssertionUtils.java
Outdated
Show resolved
Hide resolved
supported for volume, custom sql, field metric and field values assertion
mayurinehate
force-pushed
the
assertion_cli
branch
from
May 31, 2024 14:18
13d752f
to
f87fcb1
Compare
jjoyce0510
reviewed
May 31, 2024
@@ -48,6 +66,14 @@ public static Assertion map(@Nullable QueryContext context, final EntityResponse | |||
result.setInfo( | |||
mapAssertionInfo(context, new AssertionInfo(envelopedAssertionInfo.getValue().data()))); | |||
} | |||
|
|||
final EnvelopedAspect envelopedAssertionActions = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we please remove?
CI is passing! Going to go ahead and merge this in. We can continue to iterate from here. Nice MVP! |
jjoyce0510
approved these changes
May 31, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
…odels, add assertions cli with snowflake integration (datahub-project#10602)
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
…odels, add assertions cli with snowflake integration (#10602)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define data quality rules in DataHub
Step 1: Create assertions specification file
Step 2: Upsert these assertions in DataHub to view data quality expectations on entity page
Step 3: Compile and schedule these assertions to run on assertion backend of your choice (here - snowflake)
Step 4: Ingest the assertion results back in DataHub to view current status for data quality checks.
Assertions Specification File:
Simple yaml file to define assertions in declarative manner.
Assertions CLI:
Upsert command to add assertions to DataHub
datahub assertions upsert -f examples/library/assertions_configuration.yml
Compile command to compile assertions specification to chosen assertion backend.
datahub assertions compile -f examples/library/assertions_configuration.yml -p snowflake -x DMF_SCHEMA=test_db.datahub_dmfs
Ingestion
For snowflake, run ingestion with
include_assertion_results: true
to ingest assertion results back into DataHubChecklist