Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphql) data contract resolvers for graphql #10618

Merged
merged 2 commits into from
Jun 1, 2024
Merged

feat(graphql) data contract resolvers for graphql #10618

merged 2 commits into from
Jun 1, 2024

Conversation

jayacryl
Copy link
Collaborator

@jayacryl jayacryl commented May 30, 2024 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added product PR or Issue related to the DataHub UI/UX community-contribution PR or Issue raised by member(s) of DataHub Community labels May 30, 2024
jjoyce0510
jjoyce0510 reviewed May 30, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as CI is passing, we should be good.

@jayacryl jayacryl merged commit 979ee07 into master Jun 1, 2024
62 of 63 checks passed
@jayacryl jayacryl deleted the jp--datacontract-tab branch June 1, 2024 03:01
jayacryl added a commit that referenced this pull request Jun 1, 2024
@jayacryl
Revert "feat(graphql) data contract resolvers for graphql (#10618)"
eaf60fc 
This reverts commit 979ee07.
@jayacryl jayacryl restored the jp--datacontract-tab branch June 1, 2024 03:05
@jayacryl jayacryl mentioned this pull request Jun 1, 2024
Merged
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@jayacryl @sleeperdeep
feat(graphql) data contract resolvers for graphql (datahub-project#10618
faf8eb5 
)
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@jayacryl @yoonhyejin
feat(graphql) data contract resolvers for graphql (#10618)
2e53420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 left review comments

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayacryl @jjoyce0510