Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use type: string for enum schemas #10663

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Use type: string for enum schemas #10663

merged 3 commits into from
Jun 7, 2024

Conversation

kevin1chun
Copy link
Contributor

Enum in openapi should be modeled as type: "string", not "object"

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@kevin1chun kevin1chun requested a review from david-leifker June 7, 2024 20:25
@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Jun 7, 2024
@kevin1chun kevin1chun enabled auto-merge (squash) June 7, 2024 20:26
david-leifker
david-leifker requested changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@david-leifker david-leifker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Task :metadata-service:openapi-servlet:test

Gradle suite > Gradle test > io.datahubproject.openapi.v3.OpenAPIV3GeneratorTest > testOpenApiSpecBuilder FAILED
java.lang.AssertionError at OpenAPIV3GeneratorTest.java:46

2 tests completed, 1 failed

@kevin1chun kevin1chun requested a review from david-leifker June 7, 2024 22:08
@kevin1chun kevin1chun merged commit 812bcbb into datahub-project:master Jun 7, 2024
35 of 36 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@kevin1chun @sleeperdeep
Use type: string for enum schemas (datahub-project#10663)
ac1bec0
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@kevin1chun @yoonhyejin
Use type: string for enum schemas (#10663)
57bfeb4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment publish-docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin1chun @david-leifker