feat(ui): Display 'View in Gitlab' if externalUrl is a link to Gitlab #10668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…utton feat(ui): Display 'View in Github' if externalUrl is link to GitHub
github-actions
bot
added
product
hsheth2
approved these changes
Jun 11, 2024
sleeperdeep
pushed a commit
to sleeperdeep/datahub
that referenced
this pull request
Jun 25, 2024
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Currently, if Github links are present the "View in .. " button gets changed to "View in Github". However, if there are gitlab links are present, it still points to the platform name. So for example, if the platform is Looker, even though there is a GitLab link present, it shows "View in Looker" in the UI. If you click on it, it goes to the Gitlab page. So this MR changes it to "View in Gitlab"