Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aspect refs inside entity schema are nullable #10695

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Aspect refs inside entity schema are nullable #10695

merged 2 commits into from
Jun 12, 2024

Conversation

kevin1chun
Copy link
Contributor

Fix for openapi v3 spec:

  • Make aspect ref inside entity schemas as nullable fields

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@kevin1chun kevin1chun requested a review from david-leifker June 12, 2024 20:56
@github-actions github-actions bot added devops PR or Issue related to DataHub backend & deployment community-contribution PR or Issue raised by member(s) of DataHub Community labels Jun 12, 2024
@david-leifker david-leifker enabled auto-merge (squash) June 12, 2024 20:58
@david-leifker david-leifker merged commit 241a654 into datahub-project:master Jun 12, 2024
33 of 35 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Jun 25, 2024
@kevin1chun @sleeperdeep
Aspect refs inside entity schema are nullable (datahub-project#10695)
bbc3d78 
LGTM!
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@kevin1chun @yoonhyejin
Aspect refs inside entity schema are nullable (#10695)
c004a71 
LGTM!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-leifker david-leifker david-leifker approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community devops PR or Issue related to DataHub backend & deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevin1chun @david-leifker