Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(data quality): custom assertions models, graphql, sdk #10761

Merged
merged 2 commits into from
Jun 25, 2024
Merged

feat(data quality): custom assertions models, graphql, sdk #10761

merged 2 commits into from
Jun 25, 2024

Conversation

mayurinehate
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX devops PR or Issue related to DataHub backend & deployment smoke_test Contains changes related to smoke tests labels Jun 21, 2024
jjoyce0510
jjoyce0510 reviewed Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please make sure that "com.linkedin.gms.factory.assertion",
is inside of the MaeConsumerApplication.java class for this PR?

https://github.com/datahub-project/datahub/blob/master/metadata-jobs/mae-consumer-job/src/main/java/com/linkedin/metadata/kafka/MaeConsumerApplication.java

This needs to have it so that it can create the AssertionService

@jjoyce0510
Copy link
Collaborator

Once that change is addressed, everything else looks good to me

@mayurinehate
Copy link
Collaborator Author

Can you please make sure that "com.linkedin.gms.factory.assertion", is inside of the MaeConsumerApplication.java class for this PR?

https://github.com/datahub-project/datahub/blob/master/metadata-jobs/mae-consumer-job/src/main/java/com/linkedin/metadata/kafka/MaeConsumerApplication.java

This needs to have it so that it can create the AssertionService

Done

jjoyce0510
jjoyce0510 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- Thank you!

@jjoyce0510 jjoyce0510 merged commit 5735d9e into datahub-project:master Jun 25, 2024
61 of 65 checks passed
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@mayurinehate @yoonhyejin
feat(data quality): custom assertions models, graphql, sdk (#10761)
e8c4e3f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjoyce0510 jjoyce0510 jjoyce0510 approved these changes

Assignees
No one assigned
Labels
devops PR or Issue related to DataHub backend & deployment ingestion PR or Issue related to the ingestion of metadata product PR or Issue related to the DataHub UI/UX smoke_test Contains changes related to smoke tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayurinehate @jjoyce0510