Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: hivePlatformAlias is different #10765

Merged
merged 3 commits into from
Jul 1, 2024
Merged

docs: hivePlatformAlias is different #10765

merged 3 commits into from
Jul 1, 2024

Conversation

ssilb4
Copy link
Contributor

@ssilb4 ssilb4 commented Jun 23, 2024 •
edited
Loading

metadata.dataset.hivePlatformAlias is different from docs and code

https://github.com/treff7es/datahub/blob/6fa2ef96c7cdcdd1a6160803787fee4aca5d9290/metadata-integration/java/spark-lineage-beta/src/main/java/datahub/spark/conf/SparkConfigParser.java#L43

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added ingestion PR or Issue related to the ingestion of metadata community-contribution PR or Issue raised by member(s) of DataHub Community labels Jun 23, 2024
@ssilb4 ssilb4 changed the title Update README.md docs: hivePlatformAlias is different Jun 23, 2024
@ssilb4
Copy link
Contributor Author

ssilb4 commented Jun 25, 2024

@treff7es can you check this?

hsheth2
hsheth2 approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@hsheth2 hsheth2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hsheth2 hsheth2 added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Jun 26, 2024
@anshbansal anshbansal merged commit 7fb56ef into datahub-project:master Jul 1, 2024
25 checks passed
yoonhyejin pushed a commit that referenced this pull request Jul 16, 2024
@ssilb4 @hsheth2 @yoonhyejin
docs: hivePlatformAlias is different (#10765)
20635ca 
Co-authored-by: Harshal Sheth <[email protected]>
aviv-julienjehannet pushed a commit to aviv-julienjehannet/datahub that referenced this pull request Jul 17, 2024
@ssilb4 @hsheth2 @aviv-julienjehannet
docs: hivePlatformAlias is different (datahub-project#10765)
0c76788 
Co-authored-by: Harshal Sheth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

Assignees
No one assigned
Labels
community-contribution PR or Issue raised by member(s) of DataHub Community ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ssilb4 @hsheth2 @anshbansal