fix(ui/data-contract): fix freshness & schema assertion is not working #10795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
product
amit-apptware
commented
Jun 27, 2024
| @@ -227,10 +227,10 @@ export const getAssertionsSummary = (assertions: Assertion[]): AssertionStatusSu | |||
| // */ | |||
| export const createAssertionGroups = (assertions: Array<Assertion>): AssertionGroup[] => { | |||
| // Pre-sort the list of assertions based on which has been most recently executed. | |||
| assertions.sort(sortAssertions); | |||
| const newAssertions = [...assertions].sort(sortAssertions); | |||
There was a problem hiding this comment.
sometime it throwing error because of the modify an array that has been marked as read-only
jayacryl
approved these changes
Jun 27, 2024
| assertionInfo={record.datasetAssertionInfo} | ||
| /> | ||
| ) : ( | ||
| <AssertionDescriptionContainer>{description}</AssertionDescriptionContainer> |
There was a problem hiding this comment.
if there is no description, can we fallback on || 'No description provided'
| @@ -110,6 +110,21 @@ export const DataContractBuilder = ({ entityUrn, initialState, onSubmit, onCance | |||
|
|
|||
| const hasAssertions = freshnessAssertions.length || schemaAssertions.length || dataQualityAssertions.length; | |||
|
|
|||
| const onSelectFreshnessOrSchemaAssertion = (assertionUrn: string, type: string) => { | |||
| const selected = builderState[type]?.assertionUrn === assertionUrn; | |||
There was a problem hiding this comment.
does this mean user can only select one assertion of each type? Is that the expected behavior - or do we want users to select multiple assertions for each type?
There was a problem hiding this comment.
the logic is reused.. it will check for particular assertions to satisfy only one assertion for freshness and Schema.
| } | ||
| tags { | ||
| ...globalTagsFields | ||
| } | ||
| } | ||
|
|
||
| fragment assertionDetailsWithRunEvents on Assertion { |
There was a problem hiding this comment.
Don't we already have this defined in OSS? Would this be duplicate?
jayacryl
reviewed
Jun 27, 2024
| @@ -61,9 +61,7 @@ export const Assertions = () => { | |||
| const assertions = | |||
| (combinedData && combinedData.dataset?.assertions?.assertions?.map((assertion) => assertion as Assertion)) || | |||
| []; | |||
| const filteredAssertions = assertions.filter( | |||
There was a problem hiding this comment.
- make sure we display non-dataset assertions on the list
jayacryl
reviewed
Jun 27, 2024
| ) : ( | ||
| <AssertionDescriptionContainer> | ||
| {description ?? 'No description provided'} | ||
| </AssertionDescriptionContainer> |
There was a problem hiding this comment.
- fallback for description if this is not a dataset assertion (temporary handling until we port assertions list UI over form saas)
jayacryl
reviewed
Jun 27, 2024
| @@ -1,3 +1,173 @@ | |||
| fragment assertionInfo on AssertionInfo { | |||
There was a problem hiding this comment.
- fetch data for schema/freshness assertions to display contracts correctly
yoonhyejin
pushed a commit
that referenced
this pull request
Jul 16, 2024
aviv-julienjehannet
pushed a commit
to aviv-julienjehannet/datahub
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screencast.from.27-06-24.09_13_35.PM.IST.webm
Checklist