Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest): override setdefault in file-backed dict #11359

Merged
merged 1 commit into from
Sep 17, 2024
Merged

fix(ingest): override setdefault in file-backed dict #11359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions metadata-ingestion/src/datahub/utilities/file_backed_collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,13 @@ def for_mutation(
self[key] = default
return default

def setdefault(self, key: str, default: _VT) -> _VT:
# In almost all cases where setdefault is used, we want to always mark the
# value as dirty, even if the key already exists. While `for_mutation` is
# preferred, it's easy to accidentally use the default `setdefault`
# implementation in a subtly unsafe way, so we override it here.
return self.for_mutation(key, default=default)

def __delitem__(self, key: str) -> None:
in_cache = False
if key in self._active_object_cache:
Expand Down
Loading