Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: connector for Neo4j #11526
feat: connector for Neo4j #11526
Changes from 9 commits
4e91997
d4e3d1a
53c2463
bbccdca
d02b3c1
cbcfa2f
bc4cfcf
d8ad4bd
e95d403
bff830a
94e294e
28614af
5ac8fd7
c31a787
9360ce6
3153e6a
20aa223
c4a8001
12abda4
bda79bd
03c9de6
9b82a7b
ed7c368
44fad3a
bde184b
067ff52
aea2174
89b552d
ef7390a
c0e667d
b6ed703
7de1f8c
468cadf
888b33c
cc3aaeb
801dac0
e3410d4
1e274ae
25217d7
a5c6299
fbad716
1fa7f6d
6bcf5a9
01095db
b4499d8
aadd71a
f8ebd1f
1bb0005
6f94c45
ca025bc
4a07124
d18e329
92d9d65
872a4ac
c4f6953
a818783
4212e47
b163e16
4641c9f
6aed7c7
f71e7be
fc0d90f
ea69856
aee4ca5
54cbb83
71cfb7b
01dfc26
94f104d
bf888c0
2c47b19
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please follow Step 9 here and add neo4j as platform ? If you can follow Step 10 as well, that would be great but not necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe these two config options node_tag and relationship_tag can now be removed ? We need not accept subtypes as config, as they are constants.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove this recipe file. We already have one above. If not, this needs to be kept in sync with earlier changes.