Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ingest/pulsar): handle missing/invalid schema objects #11945

Merged
merged 7 commits into from
Dec 4, 2024
Merged

fix(ingest/pulsar): handle missing/invalid schema objects #11945

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
76b5643
Fix schema parsing issue in Pulsar ingestion
Nov 25, 2024
f42df46
Merge branch 'master' into master-fix-schema-parsing-issue
Alice-608 Nov 25, 2024
9d082a2
Fix schema parsing issue in Pulsar ingestion and Modify the abnormal …
Nov 27, 2024
a4c0486
Merge remote-tracking branch 'origin/master-fix-schema-parsing-issue'…
Nov 27, 2024
bc7829c
Merge branch 'master' into master-fix-schema-parsing-issue
Alice-608 Nov 27, 2024
1287c6f
Fix schema parsing issue in Pulsar ingestion and Modify the abnormal …
Nov 28, 2024
39ec70c
Merge remote-tracking branch 'origin/master-fix-schema-parsing-issue'…
Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/pulsar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,17 @@ class PulsarSchema:
def __init__(self, schema):
self.schema_version = schema.get("version")

avro_schema = json.loads(schema.get("data"))
schema_data = schema.get("data")
if not schema_data:
logger.warning("Schema data is empty or None. Using default empty schema.")
schema_data = "{}"

try:
avro_schema = json.loads(schema_data)
except json.JSONDecodeError as e:
logger.error(f"Invalid JSON schema: {schema_data}. Error: {str(e)}")
avro_schema = {}

self.schema_name = avro_schema.get("namespace") + "." + avro_schema.get("name")
self.schema_description = avro_schema.get("doc")
self.schema_type = schema.get("type")
Expand Down
Loading