Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters) Fix issues with structured properties filters #11946

Conversation

chriscollins3456
Copy link
Collaborator

Fix a few issues we were seeing with structured properties that have dots in their IDs:

  • we were passing in the converted field name for structured props into toElasticsearchFieldType which would not match with a structured property entity definition since the field name strips dots and replaces them with underscores. Therefore we were always defaulting to STRING - now use the criterion field which doesn't have dots removed.
  • When there were no matches, we were just returning the converted elastic field name back to the UI which we could not resolve to a structured property entity if there were dots in it. In this case, return the criterion field instead.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the product PR or Issue related to the DataHub UI/UX label Nov 25, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 25, 2024
Copy link
Collaborator

@jjoyce0510 jjoyce0510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So long as David also acked these changes, LGTM

@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 26, 2024
@chriscollins3456 chriscollins3456 merged commit 97e3282 into datahub-project:master Dec 4, 2024
104 of 106 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants