Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(validation): additional URN validation adjustments #11973

Merged
merged 3 commits into from
Nov 28, 2024
Merged

fix(validation): additional URN validation adjustments #11973

merged 3 commits into from
Nov 28, 2024

Conversation

david-leifker
Copy link
Collaborator

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added docs Issues and Improvements to docs product PR or Issue related to the DataHub UI/UX labels Nov 27, 2024
@datahub-cyborg datahub-cyborg bot added the needs-review Label for PRs that need review from a maintainer. label Nov 27, 2024
@datahub-cyborg datahub-cyborg bot added pending-submitter-merge and removed needs-review Label for PRs that need review from a maintainer. labels Nov 27, 2024
hsheth2
hsheth2 reviewed Nov 27, 2024
View reviewed changes
docs/what/urn.md Outdated Show resolved Hide resolved
hsheth2
hsheth2 reviewed Nov 27, 2024
View reviewed changes
docs/what/urn.md Outdated Show resolved Hide resolved
@david-leifker david-leifker merged commit 9dfcc0c into datahub-project:master Nov 28, 2024
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 left review comments

@RyanHolstien RyanHolstien RyanHolstien approved these changes

Assignees
No one assigned
Labels
docs Issues and Improvements to docs pending-submitter-merge product PR or Issue related to the DataHub UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-leifker @RyanHolstien @hsheth2