fix(ingestion/iceberg): Improvements to iceberg source #11987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ingestion
datahub-cyborg
bot
added
the
needs-review
treff7es
reviewed
Nov 28, 2024
| @@ -249,7 +249,8 @@ | |||
|
|
|||
| iceberg_common = { | |||
| # Iceberg Python SDK | |||
| "pyiceberg>=0.4,<0.7", | |||
| # Kept at 0.4.0 due to higher versions requiring pydantic>2, as soon as we are fine with it, bump this dependency | |||
| "pyiceberg>=0.4.0", | |||
There was a problem hiding this comment.
Doesn't this require 0.4.0+ version, which means a newer version is fine as well?
There was a problem hiding this comment.
I don't understand the question
There was a problem hiding this comment.
ok, we discussed it and it is fine
datahub-cyborg
bot
added
pending-submitter-response
treff7es
approved these changes
Nov 28, 2024
datahub-cyborg
bot
added
pending-submitter-merge
and removed
pending-submitter-response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major point is to handle
NoSuchTableErroruntil we can update ourpyicebergdependency>=0.8.1.Introduced iceberg source to the UI recipes. Improved documentation.