fix(ingest/sagemaker): Gracefully handle missing model group #12000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
ingestion
datahub-cyborg
bot
added
the
needs-review
hsheth2
approved these changes
Dec 2, 2024
| Example: | ||
| >>> arn = "arn:aws:sagemaker:eu-west-1:123456789:model-package-group/my-model-group" | ||
| >>> get_group_name_from_arn(arn) | ||
| "my-model-group" |
There was a problem hiding this comment.
you can use doctest to automatically turn this into a unit test
we have a few examples of this in our codebase already
| full_table_name, | ||
| f"""Note: table {full_table_name} is an AWS Glue object. | ||
| logging.info( | ||
| f"""Note: table {full_table_name} is an AWS Glue object. This source does not ingest all metadata for Glue tables. |
There was a problem hiding this comment.
the """ with newlines will make the subsequent lines have weird indentation
use textwrap.dedent or do something like this
logging.info(f"""\
Note...
second line
""")
| >>> get_group_name_from_arn(arn) | ||
| "my-model-group" | ||
| """ | ||
| logger.info( |
There was a problem hiding this comment.
Suggested change
| logger.info( | |
| logger.debug( |
datahub-cyborg
bot
added
pending-submitter-merge
and removed
needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist