Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/looker): Don't fail on unknown liquid filters #12014

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(ingest/looker): Don't fail on unknown liquid filters #12014

merged 1 commit into from
Dec 3, 2024

Conversation

treff7es
Copy link
Contributor

@treff7es treff7es commented Dec 3, 2024

  • Don't fail on unknown liquid filters
  • Implement sql_quote liquid filter

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@treff7es
- Don't fail on unknown liquid filters
38a9343 
- Implement sql_quote liquid filter
@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Dec 3, 2024
@anshbansal anshbansal added the merge-pending-ci A PR that has passed review and should be merged once CI is green. label Dec 3, 2024
@treff7es treff7es merged commit 230bd26 into datahub-project:master Dec 3, 2024
77 of 104 checks passed
sleeperdeep pushed a commit to sleeperdeep/datahub that referenced this pull request Dec 17, 2024
@treff7es @sleeperdeep
fix(ingest/looker): Don't fail on unknown liquid filters (datahub-pro…
be1fa55 
…ject#12014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsheth2 hsheth2 hsheth2 approved these changes

@anshbansal anshbansal anshbansal approved these changes

Assignees
No one assigned
Labels
ingestion PR or Issue related to the ingestion of metadata merge-pending-ci A PR that has passed review and should be merged once CI is green.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@treff7es @anshbansal @hsheth2